Precompute static shader math on the CPU for EffectStack#24070
Open
Breakdown-Dog wants to merge 2 commits intobevyengine:mainfrom
Open
Precompute static shader math on the CPU for EffectStack#24070Breakdown-Dog wants to merge 2 commits intobevyengine:mainfrom
EffectStack#24070Breakdown-Dog wants to merge 2 commits intobevyengine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
inv_radiusand aspect ratio corrections were calculated inside fragment shaders.Solution
EffectStackto precompute static/invariant math on the CPU side before binding uniforms, rather than computing them per-pixel in WGSL.Additional Cleanup:
mod.rsinto a dedicated pipeline.rs to keep the main module focused on effect parameters and CPU precomputation. Pure structural refactor, no behavioral changes.Testing
post-processingruns as expected.